Skip to content

Fix(migration): Rename primary key of uploaded_files table#2649

Merged
Chartman123 merged 1 commit intomainfrom
fix/2648
Mar 19, 2025
Merged

Fix(migration): Rename primary key of uploaded_files table#2649
Chartman123 merged 1 commit intomainfrom
fix/2648

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

@Chartman123 Chartman123 commented Mar 19, 2025

This fixes #2648. It changes the primary key name parameter in the original migration and adds a new migration for existing installations that drops the old primary key and creates a new one with the new name.

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket labels Mar 19, 2025
@Chartman123 Chartman123 self-assigned this Mar 19, 2025
@Chartman123 Chartman123 added high High priority 3. to review Waiting for reviews labels Mar 19, 2025
@Chartman123 Chartman123 requested a review from susnux March 19, 2025 17:35
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Mar 19, 2025
Comment thread lib/Migration/Version040300Date20240523123456.php Outdated
@Chartman123 Chartman123 force-pushed the fix/2648 branch 2 times, most recently from 54c7e96 to 5acb07c Compare March 19, 2025 18:13
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 changed the title Fix(migration): Remove parameter from setPrimaryKey method Fix(migration): Rename primary key of uploaded_files table Mar 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.34%. Comparing base (accab7e) to head (2997992).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2649      +/-   ##
============================================
- Coverage     43.43%   43.34%   -0.10%     
- Complexity      885      887       +2     
============================================
  Files            77       78       +1     
  Lines          3361     3368       +7     
============================================
  Hits           1460     1460              
- Misses         1901     1908       +7     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123
Copy link
Copy Markdown
Collaborator Author

For the backport we need to rename the migration to match the corresponding v4 version

@Chartman123 Chartman123 requested a review from Koc March 19, 2025 22:17
@Chartman123 Chartman123 merged commit bab5936 into main Mar 19, 2025
52 of 54 checks passed
@Chartman123 Chartman123 deleted the fix/2648 branch March 19, 2025 22:33
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Mar 19, 2025
Comment thread lib/Migration/Version050004Date20250319180638.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working high High priority php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while enabling Forms: Primary index name "id" for table "oc_forms_v2_uploaded_files" collides with the constraint on table "oc_bookmarks".

3 participants